New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blueprints #70

Merged
merged 4 commits into from Mar 13, 2018

Conversation

Projects
None yet
3 participants
@simonihmig
Copy link
Collaborator

simonihmig commented Mar 11, 2018

This is the blueprints PR I had prepared, which...

  • updates the blueprints to the changes added in #65, e.g setup annotations
  • replaces the previous specific feature-unit blueprint with a more generic --type option, so you can generate features for any type of test, e.g. ember g feature foo --type=integration. Default is still acceptance
  • to support 馃憜, adds a base step.js file for all test types as part of the default blueprint, i.e. unit, integration and acceptance
  • adds imports of expect (chai) to all mocha-based step files. Previously it left the choice of assertion library to the user, bus as ember-cli-mocha ships with ember-cli-chai, and all mocha blueprints for "normal" tests are also opinionated about using expect, I think it makes sense to follow that. Tbh, I have never seen anything else used...
  • adds node tests for all of that! 馃帀

@simonihmig simonihmig referenced this pull request Mar 11, 2018

Merged

Update docs #71

@sfbwalder
Copy link
Collaborator

sfbwalder left a comment

Works in our app that uses qunit.

@simonihmig simonihmig merged commit 23618e0 into albertjan:master Mar 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@simonihmig simonihmig deleted the simonihmig:update-blueprints branch Mar 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment