From 4bb96ecb685a3236038aa74aa564f0ccd660f98f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Albert=20Ma=C3=B1osa?= Date: Mon, 22 May 2023 23:51:27 +0200 Subject: [PATCH] test(enharmonic): move `toString` test cases to each implementation (#153) --- test/src/enharmonic_test.dart | 22 ------------------- .../interval/enharmonic_interval_test.dart | 15 +++++++++++++ test/src/main.dart | 2 -- test/src/note/enharmonic_note_test.dart | 8 +++++++ 4 files changed, 23 insertions(+), 24 deletions(-) delete mode 100644 test/src/enharmonic_test.dart diff --git a/test/src/enharmonic_test.dart b/test/src/enharmonic_test.dart deleted file mode 100644 index d575c727..00000000 --- a/test/src/enharmonic_test.dart +++ /dev/null @@ -1,22 +0,0 @@ -import 'package:music_notes/music_notes.dart'; -import 'package:test/test.dart'; - -void main() { - group('Enharmonic', () { - group('.toString()', () { - test('should return a string representation of this Enharmonic', () { - expect(EnharmonicNote.c.toString(), '1 {C, D𝄫, B♯}'); - expect(EnharmonicNote.g.toString(), '8 {F𝄪, G, A𝄫}'); - expect(EnharmonicNote.dSharp.toString(), '4 {D♯, E♭}'); - - expect(EnharmonicInterval.perfectUnison.toString(), '0 {P1, d2}'); - expect(EnharmonicInterval.majorThird.toString(), '4 {M3, d4}'); - expect(EnharmonicInterval.minorSixth.toString(), '8 {A5, m6, dd7}'); - expect( - (-EnharmonicInterval.majorSixth).toString(), - 'desc 9 {desc d7, desc M6}', - ); - }); - }); - }); -} diff --git a/test/src/interval/enharmonic_interval_test.dart b/test/src/interval/enharmonic_interval_test.dart index b364e373..561e7b44 100644 --- a/test/src/interval/enharmonic_interval_test.dart +++ b/test/src/interval/enharmonic_interval_test.dart @@ -280,6 +280,21 @@ void main() { }); }); + group('.toString()', () { + test( + 'should return a string representation of this EnharmonicInterval', + () { + expect(EnharmonicInterval.perfectUnison.toString(), '0 {P1, d2}'); + expect(EnharmonicInterval.majorThird.toString(), '4 {M3, d4}'); + expect(EnharmonicInterval.minorSixth.toString(), '8 {A5, m6, dd7}'); + expect( + (-EnharmonicInterval.majorSixth).toString(), + 'desc 9 {desc d7, desc M6}', + ); + }, + ); + }); + group('.hashCode', () { test('should ignore equal EnharmonicInterval instances in a Set', () { final collection = { diff --git a/test/src/main.dart b/test/src/main.dart index fc136ac0..276c691c 100644 --- a/test/src/main.dart +++ b/test/src/main.dart @@ -1,4 +1,3 @@ -import 'enharmonic_test.dart' as enharmonic_test; import 'interval/enharmonic_interval_test.dart' as enharmonic_interval_test; import 'interval/interval_size_extension_test.dart' as interval_size_extension_test; @@ -18,7 +17,6 @@ import 'tonality/mode_test.dart' as mode_test; import 'tonality/tonality_test.dart' as tonality_test; void main() { - enharmonic_test.main(); enharmonic_interval_test.main(); interval_size_extension_test.main(); interval_test.main(); diff --git a/test/src/note/enharmonic_note_test.dart b/test/src/note/enharmonic_note_test.dart index 5166490e..00f92532 100644 --- a/test/src/note/enharmonic_note_test.dart +++ b/test/src/note/enharmonic_note_test.dart @@ -396,6 +396,14 @@ void main() { }); }); + group('.toString()', () { + test('should return a string representation of this EnharmonicNote', () { + expect(EnharmonicNote.c.toString(), '1 {C, D𝄫, B♯}'); + expect(EnharmonicNote.g.toString(), '8 {F𝄪, G, A𝄫}'); + expect(EnharmonicNote.dSharp.toString(), '4 {D♯, E♭}'); + }); + }); + group('.hashCode', () { test('should ignore equal EnharmonicNote instances in a Set', () { final collection = {EnharmonicNote.f, EnharmonicNote.aSharp};