-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dark mode switch listener on Windows and Linux #20
Conversation
Hi, thank you for your contribution. The implementation is nice and clean. However, the rationale behind At the moment, as I mentioned in #14, this is a task that I see more suitable for the GUI library. Nevertheless, if you could manage to reimplement this code through |
I have reimplemented the listener by ctypes. Feel free to try it out! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this contribution. I tested it on Windows and the code LGTM, I only have a few minor comments.
Thank you again for this. I will try to create a new release later today. |
Implemented with WIN32 API on Windows and
gsettings monitor org.gnome.desktop.interface gtk-theme
on Linux. See my comment in #14 for details.