New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped dependency-check-core version to 3.1.1 #35

Merged
merged 4 commits into from Feb 20, 2018

Conversation

2 participants
@mrtnrdl
Contributor

mrtnrdl commented Feb 19, 2018

As in Issue #34 i've bumped the version of dependency-check-core.

I'll update the PR to add cpeStartsWithFilter later - or create another PR for that. What's your preference, @albuch ?

@albuch

This comment has been minimized.

Owner

albuch commented Feb 19, 2018

Thanks @mrtnrdl, please go ahead and add it to this PR whenever you have time.

@mrtnrdl

This comment has been minimized.

Contributor

mrtnrdl commented Feb 19, 2018

I've added cpeStartsWith to the PR and it works for me. I'm not sure how your tests work, to be honest. If you'd give me a pointer, I could implement a test as well.

@albuch

This comment has been minimized.

Owner

albuch commented Feb 20, 2018

The tests (see https://www.scala-sbt.org/1.0/docs/Testing-sbt-plugins.html how they work) are integration tests for all 5 tasks of the plugin in different project configurations. So no need to add an integration test for a single new setting.
There are no unit tests right now for the plugin as I don't know how they would work/interact with sbt.
So I think we're fine here.

@albuch albuch merged commit 19d7a73 into albuch:master Feb 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mrtnrdl mrtnrdl deleted the mrtnrdl:bump-dc branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment