Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually forcing a single disc of a two-disc-plus album #85

Open
craigbox opened this issue Aug 7, 2011 · 8 comments
Open

Manually forcing a single disc of a two-disc-plus album #85

craigbox opened this issue Aug 7, 2011 · 8 comments
Milestone

Comments

@craigbox
Copy link
Contributor

craigbox commented Aug 7, 2011

I have a copy of "The Essential Michael Jackson" (http://musicbrainz.org/release/f890ca09-0b44-4539-ae13-238266b242fa) which is being half-detected:

Current possible releases:
 The Essential Michael Jackson (disc 2) (tracks found: [1-10,12-17])

However, if I try and force it with -r f890ca09-0b44-4539-ae13-238266b242fa:

Exception: len(self.tracks) 17 != len(mb_tracks) 38

(I have handily added the lengths to that exception output to debug.)

There doesn't seem to be a parameter for forcing a single disc of a two-disc (or more) MB album. Is this the case?

@alastair
Copy link
Member

alastair commented Aug 8, 2011

Interesting. Looks like it's caused by the "2 cd pack is 2 releases in mb1 but 1 release in mb2". Easiest fix is "wait for NGS support" I think :(
I'm surprised that the output says "The Essential Michael Jackson (disc 2)" - looking up the release id you've given on the webservice only shows the title as "The Essential MJ" (no disc part). Is there a different release id that is getting spat out earlier?

@craigbox
Copy link
Contributor Author

craigbox commented Aug 8, 2011

I didn't see one - albumidentify tends to overwrite text on the same line,
so it's possible there was one, but I tend to catch that kind of stuff when
it runs.

On 8 August 2011 02:47, alastair <
reply@reply.github.com>wrote:

Interesting. Looks like it's caused by the "2 cd pack is 2 releases in mb1
but 1 release in mb2". Easiest fix is "wait for NGS support" I think :(
I'm surprised that the output says "The Essential Michael Jackson (disc 2)"

  • looking up the release id you've given on the webservice only shows the
    title as "The Essential MJ" (no disc part). Is there a different release id
    that is getting spat out earlier?

Reply to this email directly or view it on GitHub:

#85 (comment)

@shweppsie
Copy link
Contributor

Yer I'm getting that a lot too. I'm just waiting for NGS support.

@alastair
Copy link
Member

alastair commented Aug 9, 2011

Looking at the webservice output (http://musicbrainz.org/ws/1/release/f890ca09-0b44-4539-ae13-238266b242fa?inc=tracks)
it looks like there is no way to split NGS releases up into >1 CD using /ws/1
I think we're going to have to fold this into "make stuff work on NGS"

@craigbox
Copy link
Contributor Author

Nice work, thanks guys!

@scottr scottr closed this as completed in bd027af Sep 19, 2011
@scottr scottr reopened this Sep 19, 2011
@scottr
Copy link
Contributor

scottr commented Sep 19, 2011

Oops wrong issue id in commit message, sorry.

@scottr
Copy link
Contributor

scottr commented Sep 25, 2011

I've been trying to figure out how to improve the situation with /ws/1... there are a number of issues since MB moved to NGS.

In this particular case, when you lookup releases by discID, (not release id) MB returns just the tracks that match the disc (even though it's the same "release" as both CDs). This means we can successfully rename multi-disc sets assuming you're matching on discID. HOWEVER: /ws/1 doesn't return the disc number, so renamealbum fails on the second disc as it doesn't know its dealing with a multi-disc set, and so doesn't name the dest directory with "disc 1", etc. This causes the second disc to fail as it has already moved the first disc into place. Sigh.

Will keep looking...

Here's an example of the /ws/1/ output when searching for the discID of the second disc of "Stadium Arcadium":

http://musicbrainz.org/ws/1/release?discid=GO0PVBmjnVOrn2AWdXVm2_dCyPY-

@scottr
Copy link
Contributor

scottr commented Sep 25, 2011

It doesn't look like there's a way to go backwards once you have the releaseID from the discID to figure out which disc of the release the discID represents. Sigh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants