Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential bug with protecting/unprotecting MIDI notes #231

Closed
daveyarwood opened this issue May 27, 2016 · 4 comments
Closed

Potential bug with protecting/unprotecting MIDI notes #231

daveyarwood opened this issue May 27, 2016 · 4 comments
Labels

Comments

@daveyarwood
Copy link
Member

In 1.0.0-rc17 I implemented a little system in alda.sound.midi where a note is protected from being stopped by another note with the same MIDI number if they overlap at all. I didn't factor in the MIDI channel number at all, though, so that's probably a bug. I don't have time to investigate at the moment, so leaving this issue here as a placeholder.

@daveyarwood
Copy link
Member Author

Bug confirmed. Fix on the way.

@elydpg
Copy link
Contributor

elydpg commented May 28, 2016

great. will test once the fix has been released.

@daveyarwood
Copy link
Member Author

daveyarwood commented May 28, 2016

A little context, for posterity: the bug is that if multiple instruments play the same note at the same time, the note will only be stopped once, leaving the other one ringing out forever.

The fix is for each instrument to ignore what notes are being played by other instruments -- it doesn't matter, because those instruments are using separate MIDI channels.

daveyarwood added a commit that referenced this issue May 28, 2016
@daveyarwood
Copy link
Member Author

Fixed in 1.0.0-rc18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants