New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential bug with protecting/unprotecting MIDI notes #231
Comments
Bug confirmed. Fix on the way. |
great. will test once the fix has been released. |
A little context, for posterity: the bug is that if multiple instruments play the same note at the same time, the note will only be stopped once, leaving the other one ringing out forever. The fix is for each instrument to ignore what notes are being played by other instruments -- it doesn't matter, because those instruments are using separate MIDI channels. |
For more details, see issue #231.
Fixed in 1.0.0-rc18. |
In 1.0.0-rc17 I implemented a little system in alda.sound.midi where a note is protected from being stopped by another note with the same MIDI number if they overlap at all. I didn't factor in the MIDI channel number at all, though, so that's probably a bug. I don't have time to investigate at the moment, so leaving this issue here as a placeholder.
The text was updated successfully, but these errors were encountered: