New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget title escaping can break use of the widget_title filter #37

Closed
mlang38 opened this Issue Sep 7, 2018 · 3 comments

Comments

Projects
2 participants
@mlang38

mlang38 commented Sep 7, 2018

Hello,
in the commit 1c4dfef, the widget title has been wrapped with esc_html().
But I think (and I do it myself) that the widget_title filter is often used by themes for CSS styling purposes by wrapping the title with some targetable markup. If the HTML of the title is escaped, this usage is therefore broken. I think this behavior should be reverted.

By the way, the widget_title filter is called with the instance title only, but this filter accepts more arguments to better target the widgets to be customized.

Anyway, thank you for this very useful plugin

@aldolat aldolat self-assigned this Sep 7, 2018

@aldolat aldolat added the Bug label Sep 7, 2018

@aldolat aldolat added this to To do in Development via automation Sep 7, 2018

@aldolat

This comment has been minimized.

Show comment
Hide comment
@aldolat

aldolat Sep 7, 2018

Owner

Hello,
you're absolutely right. Thank you for your comment. 👍

I made two distinct commits in develop branch:

Please, let me know if you have additional comments on this.

Owner

aldolat commented Sep 7, 2018

Hello,
you're absolutely right. Thank you for your comment. 👍

I made two distinct commits in develop branch:

Please, let me know if you have additional comments on this.

@aldolat aldolat moved this from To do to In progress in Development Sep 7, 2018

@mlang38

This comment has been minimized.

Show comment
Hide comment
@mlang38

mlang38 Sep 10, 2018

It seems okay to me for now. Thank you very much

mlang38 commented Sep 10, 2018

It seems okay to me for now. Thank you very much

@aldolat

This comment has been minimized.

Show comment
Hide comment
@aldolat

aldolat Sep 10, 2018

Owner

I will release the 4.7.1 version in the upcoming days. Thank you so much for your report.

Owner

aldolat commented Sep 10, 2018

I will release the 4.7.1 version in the upcoming days. Thank you so much for your report.

@aldolat aldolat closed this Sep 10, 2018

Development automation moved this from In progress to Done Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment