Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid disclaimer from ikeapack #153

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

ikkerens
Copy link
Contributor

I'm not sure why this comment was added, but it is not correct, ikeapack supports float32/float64 just fine, and always has.

The reason why I didn't use float64 for a field called Money is because using float for Money is not a good idea, and I was a little cheeky at the time :)

@alecthomas alecthomas merged commit 31bbd85 into alecthomas:master Jun 13, 2024
2 checks passed
@matheusd
Copy link
Contributor

I'm not sure why this comment was added, but it is not correct, ikeapack supports float32/float64 just fine, and always has.

In that case, IMO the serializer should be modified to actually use a float64 field in order to demonstrate that it does support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants