Skip to content
This repository has been archived by the owner on Apr 10, 2019. It is now read-only.

Issue alecthomas/gometalinter#118 - add client9/misspell #134

Merged
merged 1 commit into from Jun 11, 2016
Merged

Issue alecthomas/gometalinter#118 - add client9/misspell #134

merged 1 commit into from Jun 11, 2016

Conversation

client9
Copy link
Contributor

@client9 client9 commented Jun 11, 2016

This adds https://github.com/client9/misspell Since it applies to English (which is not required by golang) and possibility of false positives, it is disabled by default. This matches gofmt and lll. But happy to make it on-by-default.

To test,

first remove misspell if it exists

rm `which misspell`

test install

go run main.go --install --update
which misspell

test lint by making junk.go that contains something like // TOOD: write code

go run main.go -enable misspell .

You should get something like this:

junk.go:3:3:warning: found "TOOD:" a misspelling of "TODO:" (misspell)

onward!

n

@alecthomas
Copy link
Owner

Excellent. I think disabled by default makes sense for misspell, thanks!

@alecthomas alecthomas merged commit a5b3685 into alecthomas:master Jun 11, 2016
client9 pushed a commit to client9/misspell that referenced this pull request Jun 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants