New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue alecthomas/gometalinter#118 - add client9/misspell #134

Merged
merged 1 commit into from Jun 11, 2016

Conversation

Projects
None yet
2 participants
@client9
Contributor

client9 commented Jun 11, 2016

This adds https://github.com/client9/misspell Since it applies to English (which is not required by golang) and possibility of false positives, it is disabled by default. This matches gofmt and lll. But happy to make it on-by-default.

To test,

first remove misspell if it exists

rm `which misspell`

test install

go run main.go --install --update
which misspell

test lint by making junk.go that contains something like // TOOD: write code

go run main.go -enable misspell .

You should get something like this:

junk.go:3:3:warning: found "TOOD:" a misspelling of "TODO:" (misspell)

onward!

n

@alecthomas

This comment has been minimized.

Show comment
Hide comment
@alecthomas

alecthomas Jun 11, 2016

Owner

Excellent. I think disabled by default makes sense for misspell, thanks!

Owner

alecthomas commented Jun 11, 2016

Excellent. I think disabled by default makes sense for misspell, thanks!

@alecthomas alecthomas merged commit a5b3685 into alecthomas:master Jun 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

client9 added a commit to client9/misspell that referenced this pull request Jun 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment