Add linter lll

[walle]

This commit adds lll (Line Length Linter) (https://github.com/walle/lll)

[alecthomas]

I'm not opposed to this, but there are a couple of problems:

1. No way to change the default line length. A flag should be plumbed through in in a similar way to how --cyclo-over.
2. It should pass -g by default.
3. It recurses by default. Even though it's fast, with vendored source this can still take quite some time.

[alecthomas]

I'm not opposed to this, but there are a couple of problems:

1. No way to change the default line length. A flag should be plumbed through in in a similar way to how --cyclo-over.
2. It should pass -g by default.
3. It recurses by default. Even though it's fast, with vendored source this can still take quite some time.

[walle]

I've fixed number one and two, in the latest commit.
Regarding number tree, the vendor dir is skipped by default, like in dupl (https://github.com/mibk/dupl) and can be included by using the --vendor flag.

[walle]

I've fixed number one and two, in the latest commit.
Regarding number tree, the vendor dir is skipped by default, like in dupl (https://github.com/mibk/dupl) and can be included by using the --vendor flag.

[alecthomas]

Thanks!

gometalinter explicitly uses dupl ./*.go to prevent it recursing. I've also had to fork gocyclo to do the same. It's not specifically about the "vendor" directory, but more about total directory size. Data files, etc.

That said, it looks like lll can be run with wildcards, so if you can also change the line to lll -g -l {maxlinelength} ./*.go I'll merge it in.

[alecthomas]

Thanks!

gometalinter explicitly uses dupl ./*.go to prevent it recursing. I've also had to fork gocyclo to do the same. It's not specifically about the "vendor" directory, but more about total directory size. Data files, etc.

That said, it looks like lll can be run with wildcards, so if you can also change the line to lll -g -l {maxlinelength} ./*.go I'll merge it in.

[walle]

No, it couldn't do that. But I have updated the project to support this, since it's a good feature.

Ok, I'll change this, should I squash my commits before you merge?

[walle]

No, it couldn't do that. But I have updated the project to support this, since it's a good feature.

Ok, I'll change this, should I squash my commits before you merge?

[alecthomas]

Perfect. Yes, please, squashing would be great.

[alecthomas]

Perfect. Yes, please, squashing would be great.

[walle]

Great, squashed them into dcbd029

[walle]

Great, squashed them into dcbd029

[alecthomas]

Thanks!

[alecthomas]

Thanks!

[alecthomas]

FYI I've disabled it by default, as it's very chatty at 80 characters. It can be explicitly enabled with --enable=lll

[alecthomas]

FYI I've disabled it by default, as it's very chatty at 80 characters. It can be explicitly enabled with --enable=lll

[walle]

Aha, ok. I saw that you added some documentation in the readme, I just realised that I had missed that, great.

[walle]

Aha, ok. I saw that you added some documentation in the readme, I just realised that I had missed that, great.