Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct line number for json example #265

Merged
merged 2 commits into from Jan 24, 2022
Merged

fix: correct line number for json example #265

merged 2 commits into from Jan 24, 2022

Conversation

leon332157
Copy link
Contributor

@leon332157 leon332157 commented Jan 24, 2022

Fixed the line number for json example in test.

README.md Outdated
@@ -392,7 +392,7 @@ Kong support a nested data structure as well with `embed:""`. You can combine `e
var CLI struct {
Logging struct {
Level string `enum:"debug,info,warn,error" default:"info"`
Type string `enum:"json,console" default:"console"`
Type string `enum:"https://github.com/alecthomas/kong/blob/3987efba8647711f11290d443e07106f22f7393f/resolver_test.go#L206,console" default:"console"`
Copy link
Owner

@alecthomas alecthomas Jan 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct?

Copy link
Contributor Author

@leon332157 leon332157 Jan 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't intend that change. I only intended to change line 586, sorry.

@alecthomas alecthomas merged commit 38c5622 into alecthomas:master Jan 24, 2022
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants