Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging issue 280 with master changes #296

Merged
merged 2 commits into from Sep 20, 2022
Merged

Merging issue 280 with master changes #296

merged 2 commits into from Sep 20, 2022

Conversation

jh125486
Copy link
Sponsor Contributor

Merging #280 with master for this PR.

@alecthomas
Copy link
Owner

Awesome thanks. Good tests! Just one minor change please.

README.md Outdated
@@ -60,26 +60,26 @@ package main
import "github.com/alecthomas/kong"

var CLI struct {
Rm struct {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert these whitespace changes please?

Copy link
Sponsor Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks like my IDE was being too helpful :/

@alecthomas
Copy link
Owner

Apologies for such an epic delay in responding, and thanks again.

@alecthomas alecthomas merged commit 0c6a9f3 into alecthomas:master Sep 20, 2022
@jh125486 jh125486 deleted the issue_280 branch Sep 20, 2022
@michal-kralik
Copy link
Contributor

@alecthomas When do you expect to make a new release with this change?

@alecthomas
Copy link
Owner

Thanks for the reminder, I tagged 0.7.0!

@michal-kralik
Copy link
Contributor

You're awesome 🎉
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants