Export tag.items -> tag.Items #471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes item public, so that consumers can see their own tags. This
helps (e.g.) building completion generators that want to use their
custom tags on the struct.
Taking a *kong.Node as n, and:
~~~ go
for i, f := range n.Flags {
fmt.Printf("%d %v\n", i, f.Tag.Items["completion"])
}
~~~
shows the value of the (custom) completion tag.
Signed-off-by: Miek Gieben <miek@miek.nl>
|
Closes: #470 |
|
Why did tag.Get() not suffice? |
that did not gave me tags that kong didn't know about. But now that I have an easy way to test I'll double check. |
|
Yep that also works. Maybe this is a documention issue? Or maybe it's me. Closing this and the issue as this works with the current code. Thanks for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes item public, so that consumers can see their own tags. This helps (e.g.) building completion generators that want to use their custom tags on the struct.
Taking a *kong.Node as n, and:
shows the value of the (custom) completion tag.