New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting boolean config options to false #6

Merged
merged 1 commit into from Oct 28, 2016

Conversation

Projects
None yet
2 participants
@TuckerWhitehouse
Copy link
Contributor

TuckerWhitehouse commented Oct 28, 2016

Setting isShowIssues to false is not possible with the existing code, because any "falsy" value will be reverted to the default.

Support setting boolean config options to false
Setting isShowIssues to false is not possible with the existing code, because any "falsy" value will be reverted to the default.
@aleen42

This comment has been minimized.

Copy link
Owner

aleen42 commented Oct 28, 2016

Thanks for debugging. @TuckerWhitehouse

@aleen42 aleen42 merged commit 2c5cb3d into aleen42:master Oct 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@TuckerWhitehouse TuckerWhitehouse deleted the TuckerWhitehouse:patch-1 branch Oct 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment