Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You just want to submit a PR for this in Teaspoon proper? #1

Closed
jejacks0n opened this issue Feb 24, 2015 · 2 comments
Closed

You just want to submit a PR for this in Teaspoon proper? #1

jejacks0n opened this issue Feb 24, 2015 · 2 comments

Comments

@jejacks0n
Copy link
Collaborator

Might be easier for me to maintain long term.. would only need a quick screenhero session or something so you can explain the few bits that I don't fully understand.

Thanks for the library, and if you don't want to include it in Teaspoon that's ok too.

@alejandrobabio
Copy link
Owner

Jeremy, I think we can join at 19 hs on Denver, 23 here (utc-3), today, tomorrow or any of these days. I don't have screenhero user, but you can invite me (screenhero has closed the signups). Or by Google Hangouts. Let me know if you can.

@alejandrobabio
Copy link
Owner

BTW, I think that spring-commands-teaspoon might not be part of Teaspoon. The same way that Rspec don't include spring-commands-rspec, the same as Cucumber. As a developer, you can chose if you want Spring or no from your Gemfile. On the other hand, Spring users know that they must add spring-commands for any not standard Rails tool that they use (like Rspec, Cucumber, or Teaspoon).

Some of the history of spring-commands here: rails/spring#79 and rails/spring#164.

I don't need to say that: but, this library is released under MIT Licence terms. You are free to copy and include it on Teaspoon. But I think the users of Spring doesn't expect that.

If you want to chat about this, or the internal of this library, of course, contact me and we'll do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants