Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editable Input Fields #85

Merged
merged 4 commits into from Sep 7, 2020
Merged

Editable Input Fields #85

merged 4 commits into from Sep 7, 2020

Conversation

TeorikDeli
Copy link
Collaborator

Added shader graph kinda serializefield support. Added an example node.
Screen Shot 2020-09-05 at 15 44 19

@TeorikDeli
Editable Input Fields
ebc8bae 
Added shader graph kinda serializefield support. Added an example node.
@TeorikDeli TeorikDeli mentioned this pull request Sep 5, 2020
Closed
@alelievr
Copy link
Owner

alelievr commented Sep 7, 2020

Hey!

I changed a few things in your PR:

  • I added a new attribute to explicitly tell the field to be a drawer, instead of using the [SerializeField]:
	[Input(name = "Vector 4"), ShowAsDrawer]
  • And I fixed an issue with the field value not being set to the value of the drawer after the edge was disconnected from the port (the bug was already here before but I didn't saw it)

@alelievr alelievr self-requested a review September 7, 2020 21:52
alelievr
alelievr approved these changes Sep 7, 2020
View reviewed changes
Copy link
Owner

@alelievr alelievr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alelievr alelievr merged commit 9b9475d into master Sep 7, 2020
github-actions bot pushed a commit that referenced this pull request Sep 7, 2020
@alelievr
Editable Input Fields (#85)
e04eb80 
* Editable Input Fields

Added shader graph kinda serializefield support. Added an example node.

* renamed few things and fixed a value not reseted but

Co-authored-by: Antoine Lelièvre <antoinel@unity3d.com>
@alelievr alelievr deleted the editable-input-fields branch June 7, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alelievr alelievr alelievr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TeorikDeli @alelievr