Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merkle tree does extra hashing that increases the cost in POSW #73

Closed
kobigurk opened this issue May 7, 2020 · 2 comments
Closed

Merkle tree does extra hashing that increases the cost in POSW #73

kobigurk opened this issue May 7, 2020 · 2 comments
Labels
feature New feature or request

Comments

@kobigurk
Copy link
Contributor

kobigurk commented May 7, 2020

The native Merkle tree implementation is doing extra hashing which is not crucial:

Both of them are not necessary for correctness/security (although hashing the leaves is standard practice).

If we remove these then the proof can be focused on hashing the transaction IDs, resulting in a higher possible capacity.

@kobigurk kobigurk added the feature New feature or request label May 7, 2020
@howardwu
Copy link
Contributor

What's the status on this?

@kobigurk
Copy link
Contributor Author

kobigurk commented Jun 3, 2020

The root hash being hashed is fixed and merged as of https://github.com/AleoHQ/snarkOS/pull/98 (this was actually a bug for full trees).

The hashed leaves are not relevant anymore for POSW, which now receives subroots.

@kobigurk kobigurk closed this as completed Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants