Skip to content

Conversation

@nesitor
Copy link
Member

@nesitor nesitor commented Oct 28, 2025

Fix: Solved issue that a credit VM is stopped when receive the allocations request from the scheduler.

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.
  • Documentation has been updated regarding these changes.
  • Dependencies update in the project.toml have been mirrored in the Debian package build script packaging/Makefile

Changes

Added credits payment method as an exception to not handle the VM from the scheduler allocations.

@nesitor nesitor requested a review from odesenfans October 28, 2025 17:07
@nesitor nesitor self-assigned this Oct 28, 2025
Copy link
Contributor

@odesenfans odesenfans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments on deps

@nesitor nesitor force-pushed the andres-fix-solve_credit_vms_scheduler_stop branch from 11d4b48 to c1651af Compare October 28, 2025 17:25
@nesitor nesitor requested a review from odesenfans October 28, 2025 17:26
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.81%. Comparing base (105c7f0) to head (c1651af).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/aleph/vm/models.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
+ Coverage   64.68%   64.81%   +0.13%     
==========================================
  Files          88       88              
  Lines        8160     8163       +3     
  Branches      734      734              
==========================================
+ Hits         5278     5291      +13     
+ Misses       2653     2643      -10     
  Partials      229      229              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@odesenfans odesenfans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odesenfans odesenfans merged commit dd11d1b into main Oct 29, 2025
35 of 37 checks passed
@odesenfans odesenfans deleted the andres-fix-solve_credit_vms_scheduler_stop branch October 29, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants