Skip to content

Conversation

@nesitor
Copy link
Member

@nesitor nesitor commented Nov 26, 2025

Feature: Implement network regenerate endpoint

Related ClickUp, GitHub or Jira tickets : ALEPH-761

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.
  • Documentation has been updated regarding these changes.
  • Dependencies update in the project.toml have been mirrored in the Debian package build script packaging/Makefile

Changes

Implemented a new authenticated endpoint to be able to regenerate the CRN network settings based on running VMs. This will allow to fix the network and firewall issues faster.

How to test

Get a CRN with incorrect firewall rules and execute the endpoint. It should clean all previous existing rules and re-add them in the proper way.

Notes

The endpoint have authentication to prevent executing it frequently and also have an execution lock to prevent concurrency.

@nesitor nesitor self-assigned this Nov 26, 2025
…e an authenticated endpoint that allows to clean completely the network setting and re-create it from the existing running VMs.
@nesitor nesitor force-pushed the andres-feature-implement_network_regenerate_endpoint branch from 77a9d4e to 6b66da0 Compare November 26, 2025 11:00
@nesitor nesitor changed the base branch from main to andres-fix-solve_duplicated_firewall_redirects November 26, 2025 11:00
@nesitor
Copy link
Member Author

nesitor commented Nov 26, 2025

This PR is based on this other one: #849

PLEASE, MERGE FIRST THE FIX BEFORE MERGING THAT ONE.

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 6.45161% with 87 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.11%. Comparing base (5e94bdb) to head (6b66da0).
⚠️ Report is 1 commits behind head on andres-fix-solve_duplicated_firewall_redirects.

Files with missing lines Patch % Lines
src/aleph/vm/orchestrator/views/__init__.py 6.38% 44 Missing ⚠️
src/aleph/vm/network/firewall.py 6.52% 43 Missing ⚠️
Additional details and impacted files
@@                                Coverage Diff                                 @@
##           andres-fix-solve_duplicated_firewall_redirects     #850      +/-   ##
==================================================================================
- Coverage                                           64.72%   64.11%   -0.62%     
==================================================================================
  Files                                                  88       88              
  Lines                                                8188     8281      +93     
  Branches                                              739      752      +13     
==================================================================================
+ Hits                                                 5300     5309       +9     
- Misses                                               2655     2739      +84     
  Partials                                              233      233              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@1yam 1yam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nesitor nesitor merged commit 4372f97 into andres-fix-solve_duplicated_firewall_redirects Nov 27, 2025
20 of 22 checks passed
@nesitor nesitor deleted the andres-feature-implement_network_regenerate_endpoint branch November 27, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants