[Config] Remove dependency to API in non-API code #231
Conversation
|
Depends on #229. |
hoh
left a comment
hoh
left a comment
There was a problem hiding this comment.
Great fix.
A few comments I'd like to discuss.
| } | ||
|
|
||
|
|
||
| app_config = Config(schema=get_defaults()) |
There was a problem hiding this comment.
I see multiple uses of aleph.config.app_config. Why not using aleph.config.get_config() everywhere and marking this variable as private with a _ prefix ?
There was a problem hiding this comment.
Is this variable useful versus using @lru_cache on def get_config() ?
There was a problem hiding this comment.
It conveys the intent better IMO. Using LRU cache when there's only one return value seems a bit counterintuitive.
There was a problem hiding this comment.
I think the usage in job_utils.py is legit as we need to initialize the global variable. The other one in get_ipfs_api looks like an oversight from my part.
odesenfans
force-pushed
the
od-remove-dependency-to-web-app-in-jobs
branch
from
39b60fc to
6a9fe97
Compare
odesenfans
force-pushed
the
od-remove-dependency-to-web-app-in-jobs
branch
from
6a9fe97 to
70b4bd2
Compare
Removed all dependencies to the aiohttp app object in non-API code. This object was used all over the place to retrieve the config object. Instead, we now use a global variable to store the config object itself.
odesenfans
force-pushed
the
od-remove-dependency-to-web-app-in-jobs
branch
from
70b4bd2 to
8209122
Compare
Removed all dependencies to the aiohttp app object in non-API code. This object was used all over the place to retrieve the config object. Instead, we now use a global variable to store the config object itself.
2 participants
Removed all dependencies to the aiohttp app object in non-API code.
This object was used all over the place to retrieve the config
object. Instead, we now use a global variable to store the config
object itself.