[Tests] Database support in tests #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoh
reviewed
Apr 26, 2022
Member
hoh
left a comment
hoh
left a comment
There was a problem hiding this comment.
Looks good !
A small note on filepath that could be simplified.
Comment on lines
13
to
14
| fixtures_dir = os.path.join(os.path.dirname(__file__), "fixtures") | ||
| with open(os.path.join(fixtures_dir, fixture)) as f: |
Member
There was a problem hiding this comment.
This could be simplified using filepath.Path.
Suggested change
| fixtures_dir = os.path.join(os.path.dirname(__file__), "fixtures") | |
| with open(os.path.join(fixtures_dir, fixture)) as f: | |
| messages_path = Path(__file__).parent / "fixtures" / fixture | |
| with open(messages_path) as f: |
hoh
approved these changes
Apr 26, 2022
Added a fixture to initialize the database. This fixture initializes the collections used by a CCN in a separate database and resets it on every run. This feature will allow to write more extensive tests by preloading fixture data in the DB. Implemented a first test using the fixture for the pending TX job. On the CI side, we now spawn a service container to run MongoDB.
odesenfans
force-pushed
the
od-unit-tests-with-db
branch
from
172240b to
400b674
Compare
odesenfans
added a commit
that referenced
this pull request
Apr 27, 2022
Added a fixture to initialize the database. This fixture initializes the collections used by a CCN in a separate database and resets it on every run. This feature will allow to write more extensive tests by preloading fixture data in the DB. Implemented a first test using the fixture for the pending TX job. On the CI side, we now spawn a service container to run MongoDB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a fixture to initialize the database. This fixture initializes
the collections used by a CCN in a separate database and resets
it on every run.
This feature will allow to write more extensive tests by preloading
fixture data in the DB.
Implemented a first test using the fixture for the pending TX job.
On the CI side, we now spawn a service container to run MongoDB.