[TXs] Increase IPFS pin timeout to 2 minutes #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a warning that occurs in the TX processing loop. The logs warn about not being able to pin the chaindata files: Can't pin hash Qm... The files end up being pinned anyway, the operation just takes longer than 4 seconds. As we now know, some IPFS fetches can take up to 100s of seconds. Increased the timeout to 2 minutes to silence the warning.
hoh
approved these changes
May 5, 2022
Member
hoh
left a comment
hoh
left a comment
There was a problem hiding this comment.
LGTM, just wondering if 120s is enough when 100s is reached in testing.
Collaborator
Author
|
100s is the number that was cited at P2P Paris, I'm taking it as an upper bound if everything goes wrong. The file will be pinned in any case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a warning that occurs in the TX processing loop. The logs
warn about not being able to pin the chaindata files:
Can't pin hash Qm...
The files end up being pinned anyway, the operation just takes
longer than 4 seconds. As we now know, some IPFS fetches can take
up to 100s of seconds. Increased the timeout to 2 minutes to
silence the warning.