[Messages] Ignore confirmations in capped collection #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue where the message processing job would fail while writing a confirmation to the capped messages collection. In MongoDB, it is not possible to increase the size of a document in a capped collection. As this particular collection is only used for the websockets to advertise new messages, we now simply ignore the confirmation for this collection. Added a unit test to test the confirmation flow.
odesenfans
force-pushed
the
od-no-update-to-capped-message
branch
from
511c73f to
999a24b
Compare
hoh
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where the message processing job would fail while
writing a confirmation to the capped messages collection.
In MongoDB, it is not possible to increase the size of a document
in a capped collection. As this particular collection is only used
for the websockets to advertise new messages, we now simply
ignore the confirmation for this collection.
Added a unit test to test the confirmation flow.