[Permissions] Process unauthorized messages gracefully #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue where the check of permissions would fail if the content.address field of the message was set to a different address than the sender and the owner of this address did not authorize the sender to post message on their behalf. Added basic unit tests for the permission system.
odesenfans
force-pushed
the
od-fix-permissions-nonetype-not-iterable
branch
from
ef55bac to
3c92069
Compare
hoh
reviewed
May 9, 2022
| ] | ||
|
|
||
| # Note: type-ignore statements are required because mypy does not understand that | ||
| # the nested dictionaries we declared just above are dictionaries. |
Member
There was a problem hiding this comment.
Could this be fixed with type annotation on the variable ?
Collaborator
Author
There was a problem hiding this comment.
Technically yes, with TypedDict. But it's gonna be a PITA to maintain so I'd rather keep the type ignores. Also, there's an off-chance that this will someday be fixed in mypy. That day, the type ignore statements will trigger errors so we will know 😛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where the check of permissions would fail if
the content.address field of the message was set to a different
address than the sender and the owner of this address did not
authorize the sender to post message on their behalf.
Added basic unit tests for the permission system.