[Tests] Make API endpoints testable #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odesenfans
changed the title
It is now possible to write API tests with the test client of aiohttp. Added an example test that checks that the /version endpoint returns the expected version. Refactored the declaration of endpoints in the initialization of the app. We now have a `register_routes` function centralized in a single module. All references to the global app object inside the implementation of endpoints were replaced by accesses to `request.app`. This allows to import the app object, configured properly, without importing other files.
hoh
reviewed
May 10, 2022
| ) | ||
|
|
||
|
|
||
| def register_routes(app: web.Application): |
Member
There was a problem hiding this comment.
+1 to centralize all routes. Should we also move them to a new file src/aleph/web/routes.py to make it easier to find ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to test API endpoints with the test client of aiohttp.
Added an example test that checks that the /version endpoint returns
the expected version.
Refactored the declaration of endpoints in the initialization of
the app. We now have a
register_routesfunction centralized ina single module. All references to the global app object inside the
implementation of endpoints were replaced by accesses to
request.app.This allows to import the app object, configured properly, without
importing other files.