[Forget] Fetch less data #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odesenfans
force-pushed
the
od-fetch-less-data-in-forget
branch
from
feba6c0 to
3f5c5a0
Compare
hoh
reviewed
May 24, 2022
Member
hoh
left a comment
hoh
left a comment
There was a problem hiding this comment.
I am not a big fan of redefining multiple Message types recent PRs, but that can always be improved later and this PR improves over the current situation.
A few minor comments but nothing blocking or consequent.
| or target_info.content_item_hash is None | ||
| ): | ||
| raise ValueError( | ||
| f"Could not garbage collect content linked to STORE message {target_hash}." |
Member
There was a problem hiding this comment.
Can you make this message more explicit ? Something like:
Suggested change
| f"Could not garbage collect content linked to STORE message {target_hash}." | |
| f"Information missing, could not garbage collect content linked to STORE message {target_hash}." |
| or target_info.content_item_hash is None | ||
| ): | ||
| raise ValueError( | ||
| f"Could not garbage collect content linked to STORE message {target_hash}." |
Member
There was a problem hiding this comment.
Why put the target_hash in the string and not as another argument ?
Suggested change
| f"Could not garbage collect content linked to STORE message {target_hash}." | |
| f"Could not garbage collect content linked to STORE message", target_hash |
Collaborator
Author
There was a problem hiding this comment.
I actually never passed several values to ValueError, I see that it works (it makes the args property a tuple), is there an upside in doing this besides avoiding the string formatting?
Reduced the data usage of the forget handler in two ways. 1. Stop relying on `get_message_content` to retrieve the content of a message. As the message is guaranteed to already be on the node, we can directly get the parts of interest from the DB. 2. Only retrieve the fields relevant to the handling of the forget message from the DB. Rather than retrieving the whole content, which can be quite large, we now only retrieve the address, item type and item hash from the DB. This should improve the performance of the handler. Introduced a new class, `TargetMessageInfo`, to represent the data we fetch from the DB.
odesenfans
force-pushed
the
od-fetch-less-data-in-forget
branch
from
59f44b1 to
ccf56f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced the data usage of the forget handler in two ways.
Stop relying on
get_message_contentto retrieve the contentof a message. As the message is guaranteed to already be on
the node, we can directly get the parts of interest from the DB.
Only retrieve the fields relevant to the handling of the forget
message from the DB. Rather than retrieving the whole content,
which can be quite large, we now only retrieve the address, item
type and item hash from the DB. This should improve the performance
of the handler. Introduced a new class,
TargetMessageInfo, torepresent the data we fetch from the DB.