Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Py3k #117

Merged
merged 10 commits into from Mar 25, 2013

Conversation

Projects
None yet
3 participants
Contributor

EnTeQuAk commented Mar 23, 2013

Very simple port to Python3, does not contain any refactoring yet.

@xordoquy xordoquy and 1 other commented on an outdated diff Mar 23, 2013

docs/index.txt
@@ -4,8 +4,7 @@ Welcome to django-taggit's documentation!
``django-taggit`` is a reusable Django application designed to making adding
tagging to your project easy and fun.
-``django-taggit`` works with Django 1.1 and 1.2 (see :doc:`issues` for known
-issues with older versions of Django), and Python 2.4-2.X.
+``django-taggit`` works with Django 1.4+ and Python 2.7-3.X.
@xordoquy

xordoquy Mar 23, 2013

Contributor

Actually, it is 1.4.5+

@EnTeQuAk

EnTeQuAk Mar 23, 2013

Contributor

Fixed in a0b5da6

@xordoquy xordoquy commented on the diff Mar 23, 2013

taggit/models.py
@@ -10,7 +12,7 @@ class TagBase(models.Model):
name = models.CharField(verbose_name=_('Name'), unique=True, max_length=100)
slug = models.SlugField(verbose_name=_('Slug'), unique=True, max_length=100)
- def __unicode__(self):
+ def __str__(self):
@xordoquy

xordoquy Mar 23, 2013

Contributor

The classes should have the python_2_unicode_compatible decorator.
See https://docs.djangoproject.com/en/dev/topics/python3/#str-and-unicode-methods

@EnTeQuAk

EnTeQuAk Mar 23, 2013

Contributor

Thanks, fixed in d9fb9b1

@xordoquy xordoquy and 1 other commented on an outdated diff Mar 23, 2013

taggit/models.py
class ItemBase(models.Model):
- def __unicode__(self):
+ def __str__(self):
@xordoquy

xordoquy Mar 23, 2013

Contributor

Missing decorator (cf previous comment)

@EnTeQuAk

EnTeQuAk Mar 23, 2013

Contributor

Thanks, fixed (see previous comment)

@xordoquy xordoquy commented on the diff Mar 23, 2013

@@ -31,5 +31,5 @@
'Programming Language :: Python',
'Framework :: Django',
],
- test_suite='taggit.tests.runtests.runtests',
+ test_suite='runtests.runtests',
)
@xordoquy

xordoquy Mar 23, 2013

Contributor

We should probably add the python3 trove classifier too

@xordoquy

xordoquy Mar 23, 2013

Contributor

Also on that file, the line version=".".join(map(str, VERSION)), should probably be updated. Not sure the str will work here under python3.

@EnTeQuAk

EnTeQuAk Mar 23, 2013

Contributor

Fixed in a7bf54f, the version work pretty well with python3

@xordoquy xordoquy commented on the diff Mar 24, 2013

.travis.yml
env:
+ - DJANGO=https://github.com/django/django/archive/master.tar.gz
@xordoquy

xordoquy Mar 24, 2013

Contributor

Probably comment out master as the build won't pass yet (too many queries for a test)

@apollo13 apollo13 merged commit d9fb9b1 into alex:master Mar 25, 2013

1 check failed

default The Travis build failed
Details
Contributor

apollo13 commented Apr 23, 2013

I merged it into the develop branch I think
On Apr 23, 2013 12:13 PM, "Christopher Grebs" notifications@github.com
wrote:

@apollo13 https://github.com/apollo13 why did you close this commit
without merging it?


Reply to this email directly or view it on GitHubhttps://github.com/alex/django-taggit/pull/117#issuecomment-16849803
.

Contributor

EnTeQuAk commented Apr 23, 2013

Yeah, I were just totally blind. Sorry :-D

On Tue, Apr 23, 2013 at 12:22 PM, Florian Apolloner <
notifications@github.com> wrote:

I merged it into the develop branch I think
On Apr 23, 2013 12:13 PM, "Christopher Grebs" notifications@github.com
wrote:

@apollo13 https://github.com/apollo13 why did you close this commit
without merging it?


Reply to this email directly or view it on GitHub<
https://github.com/alex/django-taggit/pull/117#issuecomment-16849803>
.


Reply to this email directly or view it on GitHubhttps://github.com/alex/django-taggit/pull/117#issuecomment-16850162
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment