Add option to override default tag string parsing #232

Merged
merged 1 commit into from Jan 19, 2016

Projects

None yet

3 participants

@bburan
Contributor
bburan commented Apr 25, 2014

To provide some flexibility in parsing tag strings and creating tag strings from a list of tags, users can now provide their own functions for performing these operations. Fixes #215.

This is per the discussion in #215. Please let me know if there's anything else that needs to be fixed before you'll accept the PR.

@bburan
Contributor
bburan commented May 1, 2014

@apollo13 - Please let me know if the PR looks acceptable. If not, I am happy to make any changes necessary to get this accepted. It includes some unit tests and updates to the documentation for the new feature.

@apollo13
Contributor
apollo13 commented May 9, 2014

@bburan: I'll look over it at the Djangocon sprints next week.

On Thu, May 1, 2014 at 1:27 PM, bburan notifications@github.com wrote:

@apollo13 https://github.com/apollo13 - Please let me know if the PR
looks acceptable. If not, I am happy to make any changes necessary to get
this accepted. It includes some unit tests and updates to the documentation
for the new feature.


Reply to this email directly or view it on GitHubhttps://github.com/alex/django-taggit/pull/232#issuecomment-41901089
.

@frewsxcv
Collaborator

Can you do the following:

git fetch origin
git rebase origin/develop

which should:

  1. base the branch off develop instead of master
  2. pick up this change: #373 since this pr is not compatible with python 2.6
@frewsxcv
Collaborator

Respond here when you have rebased so I know to look at this

@bburan
Contributor
bburan commented Jan 18, 2016

@frewsxcv - rebased.

@frewsxcv frewsxcv and 1 other commented on an outdated diff Jan 19, 2016
taggit/utils.py
from django import VERSION
from django.utils import six
+from django.conf import settings
@frewsxcv
frewsxcv Jan 19, 2016 Collaborator

Nit: can you alphabetize this?

@bburan
bburan Jan 19, 2016 Contributor

Sure. In a new commit or should I squash all the commits into a single one?

On Mon, Jan 18, 2016 at 4:03 PM, Corey Farwell notifications@github.com
wrote:

In taggit/utils.py
#232 (comment):

from django import VERSION
from django.utils import six
+from django.conf import settings

Nit: can you alphabetize this?


Reply to this email directly or view it on GitHub
https://github.com/alex/django-taggit/pull/232/files#r50058630.

@frewsxcv
Collaborator

LGTM. Could you squash your changes into one commit?

@bburan bburan Add option to override default tag string parsing
To provide some flexibility in parsing tag strings and creating tag
strings from a list of tags, users can now provide their own functions
for performing these operations.  Fixes #215.
b6954fe
@bburan
Contributor
bburan commented Jan 19, 2016

Alphabetized imports and merged commits.

@frewsxcv
Collaborator

Thanks for your contribution! 🎉

@frewsxcv frewsxcv merged commit 5623835 into alex:develop Jan 19, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@frewsxcv
Collaborator

Just released 0.18.0 that includes this change

@bburan bburan deleted the unknown repository branch Jan 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment