Fixes #186 and #264 Unknown column app.object_id Django 1.6 #305

Merged
merged 6 commits into from Sep 10, 2015

Projects

None yet

4 participants

@kminkov
Contributor
kminkov commented Apr 3, 2015

This version is similar to the one provided in #264 but I think it shouldn't break the tests.

@kminkov kminkov referenced this pull request Apr 4, 2015
Closed

Issue #186 tentative fix #264

@devoidfury

This patch fixed the issue on a live site I'm upgrading; working now. +1

@kminkov
Contributor
kminkov commented Jul 22, 2015

@frewsxcv Do we need something more to see this committed. If I could help with something just tell me. This is really annoying issue and would be great to fix it.

@frewsxcv
Collaborator

How difficult would it be to add a regression test for this?

@kminkov
Contributor
kminkov commented Jul 22, 2015

I think it shouldn't be very hard. I will try to do it.

@kminkov
Contributor
kminkov commented Sep 10, 2015

@frewsxcv , here is the test please take a look if everything is ok.

@frewsxcv frewsxcv commented on an outdated diff Sep 10, 2015
taggit/managers.py
@@ -484,14 +484,14 @@ def _get_gfk_case_path_info(self, direct=False):
pathinfos = []
from_field = self.model._meta.pk
opts = self.through._meta
- object_id_field = _get_field(self.through, 'object_id')
+ linkfield = self.through._meta.get_field_by_name(self.m2m_reverse_field_name())[0]
@frewsxcv
frewsxcv Sep 10, 2015 Collaborator

Doesn't this variable get overwritten on the next line?

@kminkov
Contributor
kminkov commented Sep 10, 2015

Yes, my mistake I forgot to clear it out. It is fixed now

@frewsxcv
Collaborator

Thanks for your contribution @kminkov!

@frewsxcv frewsxcv merged commit 9b2bf86 into alex:develop Sep 10, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@frewsxcv
Collaborator

0.17.1 has been released that includes this change

@kminkov
Contributor
kminkov commented Sep 11, 2015

Perfect, you are welcome, and thanks for the cupcake :)

@ellisonleao ellisonleao added a commit to adrian-sgn/django-taggit that referenced this pull request Oct 2, 2015
@ellisonleao ellisonleao Merge remote-tracking branch 'alex/develop' into develop
* alex/develop: (79 commits)
  Prepare for 0.17.1 release
  Clear unused linkfield setting statement
  Fix missing import for models
  Test for getting the tags with times it is used, testing the case of #186 and #305
  Update documentation link to latest Django stable release
  Prepare for 0.17.0 release
  Prepare for 0.16.4 release
  for #333 - access _default_manager via TagBase class
  Prepare for 0.16.3 release
  fix #333 - TagBase._default_manager for existant tag check
  Prepare for 0.16.2 release
  Implemented user jcalazan's fix for an issue, and ran tests, closes # 321.
  Use international ISO 8601 dates in the changelog
  Prepare for 0.16.1 release
  fixing bug where "object_id" and pk.column were reversed
  Bump to 0.16.0, update CHANGELOG
  Add case-insensitive option for tag names.
  Patch django-taggit to fix #282
  Replace tabs with spaces
  Bump to 0.15.0, update CHANGELOG
  ...

Conflicts:
	taggit/managers.py
1da6306
@ChrisBraddock24

Thanks. This fix was very helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment