for #333 - access _default_manager via TagBase class #335

Merged
merged 1 commit into from Aug 13, 2015

Projects

None yet

2 participants

@frewsxcv frewsxcv and 1 other commented on an outdated diff Aug 10, 2015
taggit/models.py
@@ -68,8 +68,9 @@ def save(self, *args, **kwargs):
except IntegrityError:
pass
# Now try to find existing slugs with similar names
+ import ipdb; ipdb.set_trace()
@groovecoder
Contributor

Updated.

@frewsxcv
Collaborator

In case you missed it, the tests failed

@groovecoder
Contributor

@jezdez - the test failures are what I didn't understand: how to access _default_manager of TagBase which is an abstract base class.

@groovecoder
Contributor

Got the .__class__ method from IRC logs last week. Still 1 test failure I need to debug.

@groovecoder
Contributor

Updated; everything should be fixed now.

@groovecoder
Contributor

Any chance to get a merge & release for this anytime soon?

@frewsxcv frewsxcv merged commit 7af338f into alex:develop Aug 13, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@groovecoder groovecoder deleted the groovecoder:tagbase-save-existant-333 branch Aug 13, 2015
@frewsxcv
Collaborator

Released 0.16.4 with this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment