Fix all deprecation warnings #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ield.remote_field.model
| @@ -56,7 +57,22 @@ def _get_form_str(self, form_str): | |||
| return form_str | |||
|
|
|||
| def assert_form_renders(self, form, html): | |||
| self.assertHTMLEqual(str(form), self._get_form_str(html)) | |||
| # Django causes a DeprecationWarning on Python 3.3, 3.4 | |||
| if (3, 3) >= sys.version_info > (3, 5): | |||
There was a problem hiding this comment.
Won't this always evaluate to False?
There was a problem hiding this comment.
Good catch. Which means if the DeprecationWarnings are not appearing, that particular issue must have gone away... I'll look in to it.
mx-moth
force-pushed
the
deprecation-warnings
branch
from
f36bbe0
to
4f482a0
Compare
|
I fixed the backwards conditional that you spotted, properly silencing the DeprecationWarning from Django in those versions of Python. |
|
Sorry for the delay! Thanks a bunch, your contributions are greatly appreciated ✨ |
This was referenced Apr 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed all deprecation warnings from all versions of Django supported by taggit, while maintaining backwards compatibility with all currently supported versions, and with all tests passing.
This involved adding some helpers for the recently renamed
field.rel.to/field.remote_field.model, and changing the use ofadd_lazy_relationtolazy_related_operationon Django 1.9.SQL names are quoted using the correct function now, fixing #380 and #383.
on_delete=models.CASCADEhas been added to all ForeignKeys where it was missing, including in tests and migrations. This is backwards compatible with current code and projects, ason_delete=models.CASCADEwas the assumed default previously.Warnings due to different versions of unittest bundled through different version of Django have been sorted out, as has a warning from Django for Python 3.3, 3.4.
Finally, DeprecationWarnings are now show in test output. As there are no more deprecation warnings, the test output is still useable as it is before, without being polluted with lots of DeprecationWarning noise.