add and translation file #410

merged 5 commits into from May 25, 2016


None yet

3 participants

wangwenpei commented May 23, 2016 edited

thanks django-taggit, it saves my time!

this is my contribute. hope this is useful. please check it.

prydie commented May 23, 2016

CI is failing due to icorrectly ordered imports in taggit/ If you could fix this so that the rest of the test suite runs that would be great.

ERROR: /home/travis/build/alex/django-taggit/taggit/ Imports are incorrectly sorted.
wangwenpei added some commits May 24, 2016
@wangwenpei wangwenpei change import order to solve isort check 9376b01
@wangwenpei wangwenpei Merge remote-tracking branch 'upstream/master'

upgrade,please confirm it.

@prydie prydie and 1 other commented on an outdated diff May 24, 2016
@@ -0,0 +1,6 @@
+from django.apps import AppConfig as BaseConfig
+from django.utils.translation import ugettext_lazy as _
+class AppConfig(BaseConfig):
prydie May 24, 2016 Contributor

The standard around App config is to name the config class based on the module name. For example:

 # rock_n_roll/

from django.apps import AppConfig

class RockNRollConfig(AppConfig):
    name = 'rock_n_roll'
    verbose_name = "Rock ’n’ roll"

From the docs.

frewsxcv May 24, 2016 Collaborator

In other words, just rename this to TaggitAppConfig and this should be good to merge

prydie commented May 24, 2016

One suggestion code wise. Not being a Chinese speaker though I can't review the translation, unfortunately.

@wangwenpei wangwenpei rename Appconfig name

Looks great, thanks!

@frewsxcv frewsxcv merged commit 000fa9b into alex:master May 25, 2016

3 checks passed

codecov/patch 100% of diff hit (target 90.16%)
codecov/project 90.24% (+<.01%) compared to 4512c09
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment