Fix UnboundLocalError in _TaggableManager.set(..) #418

Merged
merged 1 commit into from Jun 19, 2016

Projects

None yet

4 participants

@sigvef
Contributor
sigvef commented Jun 19, 2016

Calling .set(..) with clear=True on an instance manager would produce an
UnboundLocalError. This behavior was introduced in
6542a70. This commit fixes the issue,
and adds a separate test to test the behavior of .set(..) with
clear=True.

@sigvef sigvef Fix UnboundLocalError in _TaggableManager.set(..)
Calling .set(..) with clear=True on an instance manager would produce an
UnboundLocalError. This behavior was introduced in
6542a70. This commit fixes the issue,
and adds a separate test to test the behavior of .set(..) with
clear=True.
64dd78e
@codecov-io
codecov-io commented Jun 19, 2016 edited

Current coverage is 90.67%

Merging #418 into master will increase coverage by 0.43%

@@             master       #418   diff @@
==========================================
  Files             8          8          
  Lines           697        697          
  Methods           0          0          
  Messages          0          0          
  Branches        114        114          
==========================================
+ Hits            629        632     +3   
+ Misses           55         53     -2   
+ Partials         13         12     -1   

Powered by Codecov. Last updated by 02751e7...64dd78e

@prydie
Contributor
prydie commented Jun 19, 2016 edited

How embarrassing. Thanks for the PR.

👍 from me.

@frewsxcv
Collaborator

Thanks, good catch!

@frewsxcv frewsxcv merged commit fb081a8 into alex:master Jun 19, 2016

3 checks passed

codecov/patch 100% of diff hit (target 90.24%)
Details
codecov/project 90.67% (+0.43%) compared to 02751e7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@frewsxcv
Collaborator

Released in version 0.20.0.

@sigvef sigvef deleted the sigvef:set-clear-true branch Jun 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment