Document supported versions of Django; fix Travis to test these versions. #435

Merged
merged 1 commit into from Aug 26, 2016

Projects

None yet

4 participants

@jdufresne
Contributor
jdufresne commented Aug 23, 2016 edited

Remove workarounds for unsupported, unmaintained versions of Django.

Per the 0.21 release notes, django-taggit only supports Django 1.7 and
above.

Updated docs to only refer to supported versions.


I think you should also consider dropping support for Django 1.7. Is it no longer maintained or supported upstream, including for security issues. See https://www.djangoproject.com/download/#supported-versions. If you think it is a good idea, I can update the PR to remove all 1.7 workarounds as well.

@codecov-io
codecov-io commented Aug 23, 2016 edited

Current coverage is 0.30% (diff: 0.00%)

Merging #435 into master will increase coverage by 0.01%

@@            master      #435   diff @@
========================================
  Files            8         8          
  Lines          699       666    -33   
  Methods          0         0          
  Messages         0         0          
  Branches       114       110     -4   
========================================
  Hits             2         2          
+ Misses         694       661    -33   
  Partials         3         3          

Powered by Codecov. Last update 8db427a...c650779

@timgraham timgraham commented on an outdated diff Aug 25, 2016
docs/index.txt
- Since version 0.10.0 taggit uses South for database migrations.
- This means that users who are upgrading to 0.10.0 and up will have to fake
- the initial migration, like this::
-
- python manage.py migrate taggit --fake 0001
- python manage.py migrate
-
- Since version 0.12.0 taggit uses Django migrations by default. South users
- have to adjust their settings::
-
- SOUTH_MIGRATION_MODULES = {
- 'taggit': 'taggit.south_migrations',
- }
-
- For more information, see `south documentation`__
+ Since version 0.12.0 taggit uses Django migrations by default.
@timgraham
timgraham Aug 25, 2016

I think this could be removed since Django 1.6 is no longer supported.

@timgraham

LGTM, another thing I noticed is that you can use functools.total_ordering in replace of the django import.

@jdufresne jdufresne Document supported versions of Django; fix Travis to test these versi…
…ons.

Remove workarounds for unsupported, unmaintained versions of Django.

Per the 0.21 release notes, django-taggit only supports Django 1.7 and
above.

Updated docs to only refer to supported versions.

Fixes #369
c650779
@jdufresne
Contributor

Thanks for the review! Made the recommended changes.

@frewsxcv frewsxcv merged commit 4c2382f into alex:master Aug 26, 2016

2 of 3 checks passed

codecov/patch 0.00% of diff hit (target 0.28%)
Details
codecov/project 0.30% (+0.01%) compared to 8db427a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@frewsxcv
Collaborator

Thanks for your contribution! 🎉

@jdufresne jdufresne deleted the jdufresne:drop-workarounds branch Aug 26, 2016
@pyup-bot pyup-bot referenced this pull request in mimischi/django-clock Aug 31, 2016
Closed

Update django-taggit to 0.21.2 #171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment