Support __gt__ and __lt__ ordering on Tags #456

Merged
merged 4 commits into from Jan 11, 2017

Projects

None yet

4 participants

@adam-thomas
Contributor

This makes it possible to call sort() on a list of Tag objects in memory.

adam-thomas and others added some commits Jan 9, 2017
@adam-thomas adam-thomas Add __gt__ and __lt__ overrides for TagBase.
Fixes an incompatibility with django-modelcluster and, by extension, Wagtail.

Currently untested, just committing the change to 'save' it.
94b5cc2
@adam-thomas adam-thomas Add tests for __gt__ and __lt__, here's hoping they work. f219234
@adam-thomas adam-thomas Be case-insensitive. 001303f
@todd-dembrey todd-dembrey Merge pull request #2 from incuna/tag-ordering
Add __gt__ and __lt__ overrides for TagBase.
243ccb9
@codecov-io
codecov-io commented Jan 10, 2017 edited

Current coverage is 89.51% (diff: 100%)

Merging #456 into master will increase coverage by 0.06%

@@             master       #456   diff @@
==========================================
  Files             8          8          
  Lines           683        687     +4   
  Methods           0          0          
  Messages          0          0          
  Branches        111        109     -2   
==========================================
+ Hits            611        615     +4   
  Misses           57         57          
  Partials         15         15          

Powered by Codecov. Last update 31fc5d8...243ccb9

@frewsxcv
Collaborator

Thanks!

@frewsxcv frewsxcv merged commit b773de9 into alex:master Jan 11, 2017

3 checks passed

codecov/patch 100% of diff hit (target 89.45%)
Details
codecov/project 89.51% (+0.06%) compared to 31fc5d8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam-thomas
Contributor

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment