Check for case-insensitive duplicates when creating new tags #461

Merged
merged 3 commits into from Jan 21, 2017

Projects

None yet

3 participants

@jwhitlock
Contributor

Fixes issue #460.

jwhitlock added some commits Jan 20, 2017
@jwhitlock jwhitlock Test creation of case-insensitive duplicate tags
When TAGGIT_CASE_INSENSITIVE=True, it is still possible to create
"duplicate" tags if they are added at the same time (issue #460)
b4c10d1
@jwhitlock jwhitlock Refactor _to_tag_model_instances
Combine multiple declarations of tag manager options.
37601f0
@jwhitlock jwhitlock Look for ci duplicates when creating tags
When TAGGIT_CASE_INSENSITIVE=True, check if case-insensitive tags were
created earlier in the loop. Fixes #460.
a96da42
@codecov-io
codecov-io commented Jan 20, 2017 edited

Current coverage is 89.92% (diff: 100%)

Merging #461 into master will increase coverage by 0.40%

@@             master       #461   diff @@
==========================================
  Files             8          8          
  Lines           687        695     +8   
  Methods           0          0          
  Messages          0          0          
  Branches        109        110     +1   
==========================================
+ Hits            615        625    +10   
+ Misses           57         55     -2   
  Partials         15         15          

Powered by Codecov. Last update b7d3995...a96da42

@frewsxcv
Collaborator

Thanks!

@frewsxcv frewsxcv merged commit aec962a into alex:master Jan 21, 2017

3 checks passed

codecov/patch 100% of diff hit (target 89.51%)
Details
codecov/project 89.92% (+0.40%) compared to b7d3995
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jwhitlock jwhitlock deleted the jwhitlock:ci_dupe_tags_460 branch Jan 22, 2017
@jwhitlock
Contributor
jwhitlock commented on taggit/managers.py in a96da42 Jan 25, 2017 edited

This should be name__iexact=new_tag, not name__iexact=name. Bug, PR on the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment