Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Several changes to bring testing up to speed. #78

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
  1. Tox: Use official 1.3, and start testing against trunk.
  2. Runtests: Make a default engine so that settings passes
  3. Runtests: Use class based test runner
  4. Docs: Add README.txt to _static folder, so it's created, this tox allows tests to pass.
@issackelly issackelly Several changes to bring testing up to speed.
1. Tox: Use official 1.3, and start testing against trunk. 
2. Runtests: Make a default engine so that settings passes
3. Runtests: Use class based test runner
4. Docs: Add README.txt to _static folder, so it's created, this tox allows tests to pass.
f4dc6b2

@alex alex commented on an outdated diff Aug 11, 2011

taggit/tests/runtests.py
@@ -7,6 +7,9 @@ from django.conf import settings
if not settings.configured:
settings.configure(
DATABASE_ENGINE='sqlite3',
+ DATABASES = {
+ 'default': {'ENGINE': 'django.db.backends.sqlite3'}
@alex

alex Aug 11, 2011

Owner

Please format this so that all keys in the dict are on their own line, the same was the DATABASES dict as a whole is.

@alex alex commented on the diff Aug 11, 2011

taggit/tests/runtests.py
@@ -14,7 +17,7 @@ if not settings.configured:
]
)
-from django.test.simple import run_tests
+from django.test.simple import DjangoTestSuiteRunner
@alex

alex Aug 11, 2011

Owner

Is this compatible with older djangos?

@issackelly

issackelly Aug 11, 2011

Passes down to 1.2.5, which is all you were testing against in tox
previously.

issackelly added some commits Aug 11, 2011

@issackelly issackelly Database keys on their own line. 264fc6f
@issackelly issackelly This didn't work as a thing, it throws a warning that README.txt isn'…
…t used in any toctrees, which is treated as an error in tox. Using an empty non-text file suffices though.
8793cae

@xordoquy xordoquy referenced this pull request Mar 13, 2013

Closed

Roadmap for django-taggit #112

Contributor

apollo13 commented Mar 13, 2013

I've just yanked tox and enabled travis, will think of reenabling tox again after we got a stable release :)

@apollo13 apollo13 closed this Mar 13, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment