More tests/coverage and bug fixes #34

Merged
merged 1 commit into from Jan 16, 2017

Conversation

Projects
None yet
3 participants
@tejashah88
Member

tejashah88 commented Jan 16, 2017

  • Added tests for fail cases and schemas/utterances
  • Fixed bug while trying to retrieve schema/utterances with GET request
  • Updated messages that display an error to be displayed by self.error
  • Optimized some tests to not always start a new server instance after every test
More tests/coverage and bug fixes
fixed wrong folder separations

hopefully travis CI doesn't complain about realpath problems

Fail examples should be expecting 404 error, NOT 200

fixed path problems with 'invalid_examples' folder

removed testing of failure detection when main file is not present
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 16, 2017

Coverage Status

Changes Unknown when pulling 0ec22e4 on tejashah88:master into ** on alexa-js:master**.

Coverage Status

Changes Unknown when pulling 0ec22e4 on tejashah88:master into ** on alexa-js:master**.

@dblock dblock merged commit fa1568b into alexa-js:master Jan 16, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 95.425%
Details
@dblock

This comment has been minimized.

Show comment
Hide comment
@dblock

dblock Jan 16, 2017

Collaborator

Lot of thumbs up from me! Merged.

Collaborator

dblock commented Jan 16, 2017

Lot of thumbs up from me! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment