Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error occurs when 'verify' and 'debug' are both set to true #36

Merged
merged 2 commits into from Jan 20, 2017

Conversation

Projects
None yet
3 participants
@tejashah88
Copy link
Member

commented Jan 19, 2017

This PR addresses issue #19.

@tejashah88 tejashah88 referenced this pull request Jan 19, 2017

Closed

Testing interface #19

@dblock

This comment has been minimized.

Copy link
Collaborator

commented Jan 19, 2017

Before I merge this - should it throw an error instead of silently disabling the debugger since those two options are simply incompatible?

@tejashah88

This comment has been minimized.

Copy link
Member Author

commented Jan 19, 2017

That might be a better way to handle it. I'll also organize the tests to verify that the debugger is disabled

@tejashah88

This comment has been minimized.

Copy link
Member Author

commented Jan 20, 2017

One thing though, should is actually throw an error or use self.error? I'd think it would throw an error since the config would be invalid to load anyways.

@tejashah88 tejashah88 changed the title Disabled debugger tool when `verify` option is set to `true` Error occurs when 'verify' and 'debug' are both set to true Jan 20, 2017

@coveralls

This comment has been minimized.

Copy link

commented Jan 20, 2017

Coverage Status

Coverage increased (+0.06%) to 95.484% when pulling b5b8938 on tejashah88:master into 88d739e on alexa-js:master.

@dblock

This comment has been minimized.

Copy link
Collaborator

commented Jan 20, 2017

This looks good, merging.

@dblock dblock merged commit f2bfb23 into alexa-js:master Jan 20, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.06%) to 95.484%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.