Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fixes and an actual test for firing pre/post events. #43

Merged
merged 3 commits into from Jan 28, 2017

Conversation

Projects
None yet
3 participants
@dblock
Copy link
Collaborator

commented Jan 27, 2017

See commits. Locally I am getting a failure for the first one, I think order of execution matters.

@dblock dblock changed the title Test fixes Test fixes and an actual test for debug + verify used together. Jan 27, 2017

@dblock dblock changed the title Test fixes and an actual test for debug + verify used together. Test fixes and an actual test for firing pre/post events. Jan 27, 2017

@dblock dblock referenced this pull request Jan 27, 2017

Merged

Tabs => spaces. #44

@dblock

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 27, 2017

@tejashah88 want to code review this for me and merge? thx

@coveralls

This comment has been minimized.

Copy link

commented Jan 28, 2017

Coverage Status

Coverage remained the same at 95.679% when pulling b77948f on dblock:test-fixes into 7751ae5 on alexa-js:master.

@tejashah88
Copy link
Member

left a comment

Looks good! Merging...

@tejashah88 tejashah88 merged commit e597025 into alexa-js:master Jan 28, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 95.679%
Details

@dblock dblock deleted the dblock:test-fixes branch Jan 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.