Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL Handling Upgrade #45

Merged
merged 1 commit into from Jan 30, 2017

Conversation

Projects
None yet
3 participants
@tejashah88
Copy link
Member

commented Jan 30, 2017

  • Added support for ca chain certificates (#17)
  • Added option to specify passphrase for unlocking specified SSL files
  • Modified tests to include new SSL handling features
  • Upgraded alexa-verifier-middleware to 0.1.8 from 0.1.4
  • Added npm command to examine test coverage locally
SSL Handling Upgrade
* Added support for ca chain certificates (#17)
* Added option to specify passphrase for unlocking specified SSL files
* Modified tests to include new SSL handling features
* Upgraded alexa-verifier-middleware to 0.1.8 from 0.1.4
* Added npm command to examine test coverage locally
@coveralls

This comment has been minimized.

Copy link

commented Jan 30, 2017

Coverage Status

Coverage increased (+0.3%) to 96.023% when pulling d2321d2 on tejashah88:master into 090ed96 on alexa-js:master.

@dblock

dblock approved these changes Jan 30, 2017

Copy link
Collaborator

left a comment

I made minor comments for next time. Merging.

@@ -1,6 +1,11 @@
## Changelog

### 2.3.2 (Next)
* [#45](https://github.com/alexa-js/alexa-app-server/pull/45): Added support for ca chain certificates (#17) - [@tejashah88](https://github.com/tejashah88).
* [#45](https://github.com/alexa-js/alexa-app-server/pull/45): Added option to specify passphrase for unlocking specified SSL files - [@tejashah88](https://github.com/tejashah88).
* [#45](https://github.com/alexa-js/alexa-app-server/pull/45): Modified tests to include new SSL handling features - [@tejashah88](https://github.com/tejashah88).

This comment has been minimized.

Copy link
@dblock

dblock Jan 30, 2017

Collaborator

No need to changelog test changes unless it's adding tests the first time.

* [#45](https://github.com/alexa-js/alexa-app-server/pull/45): Added support for ca chain certificates (#17) - [@tejashah88](https://github.com/tejashah88).
* [#45](https://github.com/alexa-js/alexa-app-server/pull/45): Added option to specify passphrase for unlocking specified SSL files - [@tejashah88](https://github.com/tejashah88).
* [#45](https://github.com/alexa-js/alexa-app-server/pull/45): Modified tests to include new SSL handling features - [@tejashah88](https://github.com/tejashah88).
* [#45](https://github.com/alexa-js/alexa-app-server/pull/45): Upgraded alexa-verifier-middleware to 0.1.8 from 0.1.4 - [@tejashah88](https://github.com/tejashah88).

This comment has been minimized.

Copy link
@dblock

dblock Jan 30, 2017

Collaborator

I assume this is a required change? That is the server no longer works with the older version? If so this is fine, otherwise it shouldn't be necessary.

This comment has been minimized.

Copy link
@tejashah88

tejashah88 Jan 30, 2017

Author Member

Good point. I'll remove it since it still works on 0.1.4

@@ -1,6 +1,11 @@
## Changelog

### 2.3.2 (Next)
* [#45](https://github.com/alexa-js/alexa-app-server/pull/45): Added support for ca chain certificates (#17) - [@tejashah88](https://github.com/tejashah88).

This comment has been minimized.

Copy link
@dblock

dblock Jan 30, 2017

Collaborator

Cosmetic: I usually write these changes like [#45](...), [#17](...): ..., just easier to grok.

describe("Alexa App Server with Examples & Custom Server Bindings", function() {
var testServer;
var default_NODE_TLS_REJECT_UNAUTHORIZED = process.env.NODE_TLS_REJECT_UNAUTHORIZED;

This comment has been minimized.

Copy link
@dblock

dblock Jan 30, 2017

Collaborator

This is more like old_NODE..., cosmetic.

This comment has been minimized.

Copy link
@tejashah88

tejashah88 Jan 30, 2017

Author Member

I just used that name so that the intention of the variable was easy to see.

@dblock dblock merged commit da947b5 into alexa-js:master Jan 30, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.3%) to 96.023%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.