Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #55, closes #46. Bind to both HTTP and HTTPs. #60

Merged
merged 7 commits into from Feb 4, 2017

Conversation

Projects
None yet
2 participants
@dblock
Copy link
Collaborator

commented Feb 3, 2017

@tejashah88 Please review/merge.

Closes #58.

@dblock dblock force-pushed the dblock:revert-55 branch from 99486b6 to b828ccd Feb 3, 2017

@dblock dblock force-pushed the dblock:revert-55 branch from b828ccd to fb86c1c Feb 3, 2017

@dblock

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 3, 2017

This fixes several bugs or obvious misses, too.

  • If you specify the same port for HTTP and HTTPs things break quietly, #61.
  • You cannot disable HTTP, #62.
  • Start returns instance, but we have two instances now, #63
  • The test apps were renamed for more consistency, borrowed from #56.
  • There's a more sane use of defaults with lodash, avoiding the whole undefined vs. false confusion, fixing a real bug with debug and verify being not properly defaulted.

/cc: @rickwargo, @mreinstein

dblock added some commits Feb 3, 2017

@dblock dblock force-pushed the dblock:revert-55 branch from f75b4ba to b6e76c8 Feb 3, 2017

This was referenced Feb 3, 2017

@tejashah88
Copy link
Member

left a comment

Looks good so far. Merging...

@tejashah88 tejashah88 merged commit 1461df3 into alexa-js:master Feb 4, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 96.175%
Details

@dblock dblock deleted the dblock:revert-55 branch Feb 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.