Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional request properties in test page #88

Merged

Conversation

@martincostello
Copy link
Contributor

@martincostello martincostello commented Apr 8, 2017

Relates to alexa-js/alexa-app#226.

Add support for setting the value of additional request properties in the test page.

  1. accessToken for skills which support account linking.
  2. deviceId and consentToken for skills which support the Device Address API.
  3. apiEndpoint, which is set to the values specified in the documentation based on the current locale. This also supports the Device Address API.

The timestamp property of the request is now also updated to the current date and time when the requests are loaded and posted.

Support specifying the accessToken, consentToken, deviceId and
apiEndpoint in the test page.
The apiEndpoint is set based on the currently selected locale.
Also updates the form to set the timestamp to the current date and time
when the request type is changed or when a request is posted.
Ignore the .vs and .vscode folders used by Visual Studio and Visual
Studio Code.
Update the changelog to reference this PR.
@martincostello
Copy link
Contributor Author

@martincostello martincostello commented Apr 8, 2017

I'm not sure why the Travis CI build is failing just for node 0.12.

@dblock
Copy link
Collaborator

@dblock dblock commented Apr 8, 2017

See alexa-js/alexa-app#220 for node 0.12 issues, you should remove it (with a changelog line) as these libraries are no longer compatible with that.

views/test.ejs Outdated Show resolved Hide resolved
@dblock
Copy link
Collaborator

@dblock dblock commented Apr 8, 2017

Good stuff, thanks! Fix the build, see my minor comments and this is good to go.

Remove node 0.12 from the Travis CI test matrix as it is no longer
compatible.
Default to the US endpoint (which incorporate en-US), if the locale
isn't one of either en-GB or de-DE.
Add trailing slash to EU endpoint.
@martincostello
Copy link
Contributor Author

@martincostello martincostello commented Apr 8, 2017

I've updated the code as requested. I checked the Amazon docs and the trailing / was inconsistent there, so I've just put it on both.

@dblock dblock merged commit 562d167 into alexa-js:master Apr 9, 2017
2 checks passed
@martincostello martincostello deleted the Support-Device-Id-And-Consent-Token branch Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants