Support additional request properties in test page #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support specifying the accessToken, consentToken, deviceId and apiEndpoint in the test page. The apiEndpoint is set based on the currently selected locale. Also updates the form to set the timestamp to the current date and time when the request type is changed or when a request is posted.
Ignore the .vs and .vscode folders used by Visual Studio and Visual Studio Code.
Update the changelog to reference this PR.
|
I'm not sure why the Travis CI build is failing just for node 0.12. |
|
See alexa-js/alexa-app#220 for node 0.12 issues, you should remove it (with a changelog line) as these libraries are no longer compatible with that. |
dblock
reviewed
Apr 8, 2017
|
Good stuff, thanks! Fix the build, see my minor comments and this is good to go. |
Remove node 0.12 from the Travis CI test matrix as it is no longer compatible.
Default to the US endpoint (which incorporate en-US), if the locale isn't one of either en-GB or de-DE. Add trailing slash to EU endpoint.
|
I've updated the code as requested. I checked the Amazon docs and the trailing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to alexa-js/alexa-app#226.
Add support for setting the value of additional request properties in the test page.
accessTokenfor skills which support account linking.deviceIdandconsentTokenfor skills which support the Device Address API.apiEndpoint, which is set to the values specified in the documentation based on the current locale. This also supports the Device Address API.The
timestampproperty of the request is now also updated to the current date and time when the requests are loaded and posted.