Permalink
Browse files

Added Danger.js and extracted CHANGELOG.md.

  • Loading branch information...
1 parent 72cd1f7 commit 10c43be8a636caa48db3d4100cfa54b4af585202 @dblock dblock committed Dec 14, 2016
Showing with 74 additions and 32 deletions.
  1. +4 −1 .gitignore
  2. +3 −1 .travis.yml
  3. +46 −0 CHANGELOG.md
  4. +9 −27 README.md
  5. +7 −0 dangerfile.js
  6. +5 −3 package.json
View
@@ -44,5 +44,8 @@ Temporary Items
.apdisk
/coverage
-#IDE
+# IDE
.idea
+
+# NPM
+npm-debug.log
View
@@ -20,10 +20,12 @@ install:
#- cp .env.example .env
script:
+ - "npm run-script danger"
- "npm run-script lint"
- "npm run-script test-travis"
-after_script: "cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js"
+after_script:
+ - "cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js"
notifications:
email: false
View
@@ -0,0 +1,46 @@
+## Changelog
+
+### 2.3.5 (Next)
+
+* [#90](https://github.com/matt-kruse/alexa-app/pull/90): Added [Danger](http://danger.systems), PR linter - [@dblock](https://github.com/dblock).
+* Your contribution here.
+
+### 2.3.4 (May 23, 2016)
+
+* [#68](https://github.com/matt-kruse/alexa-app/pull/68): Added support for custom slot types - [@mutexkid](https://github.com/mutexkid).
+
+### 2.3.3 (May 7, 2016)
+
+* [#59](https://github.com/matt-kruse/alexa-app/pull/59): Added full card type support - [@doapp-ryanp](https://github.com/doapp-ryanp).
+
+### 2.3.2 (Jan 11, 2016)
+
+* [#47](https://github.com/matt-kruse/alexa-app/pull/47): Fixed number output in SSML tags back to being digits - [@rickwargo](https://github.com/rickwargo).
+* [#60](https://github.com/matt-kruse/alexa-app/pull/60): Added automated tests for SSML - [@mutexkid](https://github.com/mutexkid).
+* [#57](https://github.com/matt-kruse/alexa-app/pull/57): Removed support for no longer used card subtitle - [@rickwargo](https://github.com/rickwargo).
+
+### 2.3.0 (Jan 8, 2016)
+
+* [#46](https://github.com/matt-kruse/alexa-app/pull/46): Added "numbered" to the depencies list in package.json - [@mreinstein](https://github.com/mreinstein).
+
+### 2.3.0 (Jan 4, 2016)
+
+* [#31](https://github.com/matt-kruse/alexa-app/pull/31): Added support for SSML - [@rickwargo](https://github.com/rickwargo).
+* [#38](https://github.com/matt-kruse/alexa-app/pull/38): Added `.linkAccount()` method to return Link Account card - [@christianewillman](https://github.com/christianewillman).
+* [#37](https://github.com/matt-kruse/alexa-app/pull/37): Added `request.sessionDetails.accessToken` for skills using account linking - [@christianewillman](https://github.com/christianewillman).
+* Added MIT license file - [@matt-kruse](https://github.com/matt-kruse).
+
+### 2.2.0 (Oct 26, 2015)
+
+* Bumped alexa-utterances to version 0.1.0 - [@matt-kruse](https://github.com/matt-kruse).
+* [#27](https://github.com/matt-kruse/alexa-app/issues/27): Added support for the `exhaustiveUtterances` option in alexa-utterances - [@matt-kruse](https://github.com/matt-kruse).
+* By default, alexa-app utterances now avoid the cartesian product of all slot values - [@matt-kruse](https://github.com/matt-kruse).
+
+### 2.1.5 (Oct 25, 2015)
+
+* [#26](https://github.com/matt-kruse/alexa-app/issues/26): Externalized the generation of utterances to the new alexa-utterances module (Issue #26) - [@matt-kruse](https://github.com/matt-kruse).
+
+### 2.1.4 (Sep 14, 2015)
+
+* [#17](https://github.com/matt-kruse/alexa-app/issues/17): Remove hyphen from generated numbers in utterances (Issue #17)
+* [#18](https://github.com/matt-kruse/alexa-app/issues/18): Collapse multiple whitespaces to one space in utterances - [@matt-kruse](https://github.com/matt-kruse).
View
@@ -119,12 +119,12 @@ response.linkAccount()
response.shouldEndSession(boolean end [, String reprompt] )
// Set a session variable
-// By defailt, Alexa only persists session variables to the next request. The alexa-app module
+// By defailt, Alexa only persists session variables to the next request. The alexa-app module
// makes session variables persist across multiple requests.
response.session(String attributeName, String attributeValue)
// Send the response as success
-// You don't usually need to call this. This is only required if your handler is
+// You don't usually need to call this. This is only required if your handler is
// asynchronous - for example, if it makes an http request and needs to wait for
// the response, then send it back to Alexa when finished.
response.send()
@@ -177,7 +177,7 @@ app.sessionEnded(function(request,response) {
# Execute Code On Every Request
-In addition to specific event handlers, you can define functions that will run on every request.
+In addition to specific event handlers, you can define functions that will run on every request.
## pre()
@@ -216,7 +216,7 @@ Pass an object with two properties: slots and utterances.
```javascript
app.intent('sampleIntent',
{
- "slots":{"NAME":"LITERAL","AGE":"NUMBER"},
+ "slots":{"NAME":"LITERAL","AGE":"NUMBER"},
"utterances":[ "my {name is|name's} {names|NAME} and {I am|I'm} {1-100|AGE}{ years old|}" ]
},
function(request,response) { ... }
@@ -439,7 +439,7 @@ app.intent('checkStatus', function(request,response) {
## Connect to AWS Lambda
-Amazon has documentation on how to setup your Alexa app to run in AWS Lambda.
+Amazon has documentation on how to setup your Alexa app to run in AWS Lambda.
Apps built using alexa-app have a built-in "handler" method to handle calls from AWS Lambda. You don't need to do anything different to make them work within Lambda, other than to setup the Lambda Function correctly and make sure that the Handler is set to "index.handler", which is the default value.
@@ -526,28 +526,10 @@ All named apps can be found in the alexa.apps object, keyed by name. The value i
## History
-- 2.3.2 - Jan 11, 2016
- - Fixed number output in SSML tags back to being digits
- - Added automated tests for SSML
+See [CHANGELOG](CHANGELOG.md) for details.
-- 2.3.0 - Jan 8, 2016
- - Added "numbered" to the depencies list in package.json
+## License
-- 2.3.0 - Jan 4, 2016
- - Added support for SSML
- - Added .linkAccount() method to return Link Account card
- - Added request.sessionDetails.accessToken for skills using account linking
- - Added MIT license file
-
-- 2.2.0 - Oct 26, 2015
- - Bumped alexa-utterances to version 0.1.0
- - Added support for the "exhaustiveUtterances" option in alexa-utterances (Issue #27)
- - By default, alexa-app utterances now avoid the cartesian product of all slot values
-
-- 2.1.5 - Oct 25, 2015
- - Externalized the generation of utterances to the new alexa-utterances module (Issue #26)
-
-- 2.1.4 - Sep 14, 2015
- - Remove hyphen from generated numbers in utterances (Issue #17)
- - Collapse multiple whitespaces to one space in utterances (Issue #18)
+Copyright (c) 2016 Matt Kruse
+MIT License, see [LICENSE](LICENSE.md) for details.
View
@@ -0,0 +1,7 @@
+import { danger, warn } from "danger"
+
+// did you forget to update changelog?
+const hasChangelog = danger.git.modified_files.includes("CHANGELOG.md");
+if (! hasChangelog) {
+ warn("Did you forget to update CHANGELOG.md?");
+}
View
@@ -13,8 +13,9 @@
"scripts": {
"lint": "eslint index.js;",
"coverage": "istanbul cover _mocha -- -R spec",
- "test": "mocha",
- "test-travis": "./node_modules/istanbul/lib/cli.js cover ./node_modules/mocha/bin/_mocha -- -R spec ./test/*"
+ "test": "./node_modules/.bin/mocha",
+ "test-travis": "./node_modules/istanbul/lib/cli.js cover ./node_modules/mocha/bin/_mocha -- -R spec ./test/*",
+ "danger": "./node_modules/.bin/danger"
},
"repository": {
"type": "git",
@@ -35,6 +36,7 @@
"coveralls": "^2.11.9",
"eslint": "^2.9.0",
"istanbul": "^0.4.3",
- "mocha": "^2.3.4"
+ "mocha": "^2.3.4",
+ "danger": "0.6.10"
}
}

0 comments on commit 10c43be

Please sign in to comment.