Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google fonts are added, even if set to false #293

Closed
lioman opened this issue Feb 22, 2022 · 3 comments
Closed

Google fonts are added, even if set to false #293

lioman opened this issue Feb 22, 2022 · 3 comments

Comments

@lioman
Copy link
Contributor

lioman commented Feb 22, 2022

Google fonts are imported via tipuesearch CSS and USE_GOOGLE_FONTS is ignored.

I can implement the fix myself, but want to discuss it first. One simple solution is to just ditch google fonts entirely and add host the fonts. This would be a decrease in configuration complexity, privacy and some say even speed.
With current setup it is easy to be not GDPR compliant and IMHO the risks does not outweigh the proposed benefits.

@alexandrevicenzi
Copy link
Owner

Hosting Google fonts is annoying.

I would rather make USE_GOOGLE_FONTS work everywhere and when set to false just use safe web fonts that are widely available on any computer.

GDPR should not be a problem unless you are storing user data, the only thing you may want to add is some privacy policy that mentions third-party services that you are using.

@lioman
Copy link
Contributor Author

lioman commented Feb 24, 2022

I will implement it like that. But just a side note, there is a recent German court decision that sharing the IP without consent violates tyhe GDPR: https://rewis.io/urteile/urteil/lhm-20-01-2022-3-o-1749320/

lioman added a commit to lioman/Flex that referenced this issue Feb 25, 2022
tipue search has included the font import
without respecting the settings.
alexandrevicenzi added a commit that referenced this issue Mar 8, 2022
#293: respect use_google_fonts in tipue search
@alexandrevicenzi
Copy link
Owner

Fixed by #294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants