Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close the addthis relatedposts div, and only include it if addthis is enabled #144

Merged
merged 1 commit into from Feb 26, 2018

Conversation

olipratt
Copy link
Contributor

@olipratt olipratt commented Feb 24, 2018

Hi,

Because this I hope is just a really minor fix, I've just opened a PR with the fix rather than open an issue - but if you'd prefer discussion in an issue first let me know and I'll raise one.

I just took an updated version of this theme, and noted that an addthis div has appeared on all articles despite me not using that feature, and also that the div wasn't closed.

This small fix just closes the div (assuming it's supposed to be closed), and only adds it if ADD_THIS_ID is set, to match the block of configuration a few lines above.

Also, I built the test pages and checked this worked correctly both with and without ADD_THIS_ID set.

Thanks again for creating and maintaining this theme!

@alexandrevicenzi alexandrevicenzi merged commit cbc9cd6 into alexandrevicenzi:master Feb 26, 2018
@alexandrevicenzi
Copy link
Owner

Thanks for this PR. It shouldn't be added if you don't use Add This.

@alexandrevicenzi alexandrevicenzi added this to the 2.2.0 milestone Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants