Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Piwik #15

Merged
merged 1 commit into from Nov 21, 2015
Merged

Conversation

@bnjbvr
Copy link
Contributor

@bnjbvr bnjbvr commented Nov 18, 2015

Hi! Thank you for this awesome pelican theme. Please find here a PR that allows one to support Piwik integration (it's like Google Analytics but self-hosted), if the PIWIK_SITE_ID and PIWIK_URL are set in the configuration.

@@ -98,5 +98,25 @@
<script type="text/javascript" src="//s7.addthis.com/js/300/addthis_widget.js#pubid={{ ADD_THIS_ID }}" async="async"></script>
{% endif %}
{% block additional_js %}{% endblock %}

{% if PIWIK_URL %}
Copy link
Owner

@alexandrevicenzi alexandrevicenzi Nov 20, 2015

Why not an and? I think it's better then 2 ifs.

@alexandrevicenzi
Copy link
Owner

@alexandrevicenzi alexandrevicenzi commented Nov 20, 2015

Hi @bnjbvr, thanks for this integration.

Could you just take a look in my comment?

@bnjbvr
Copy link
Contributor Author

@bnjbvr bnjbvr commented Nov 21, 2015

@alexandrevicenzi indeed, I didn't know I could do that. I've updated my commit, can you take another look, please? Cheers!

alexandrevicenzi added a commit that referenced this issue Nov 21, 2015
@alexandrevicenzi alexandrevicenzi merged commit ba5405d into alexandrevicenzi:master Nov 21, 2015
@alexandrevicenzi
Copy link
Owner

@alexandrevicenzi alexandrevicenzi commented Nov 21, 2015

Thanks @bnjbvr.

Could you update the wiki? There's a place for config variables 😄

@bnjbvr
Copy link
Contributor Author

@bnjbvr bnjbvr commented Nov 22, 2015

And that's done. Thank you for merging.

@alexandrevicenzi
Copy link
Owner

@alexandrevicenzi alexandrevicenzi commented Nov 23, 2015

Nice @bnjbvr 😉

@alexandrevicenzi alexandrevicenzi added this to the 1.2 milestone Nov 25, 2015
@bnjbvr bnjbvr deleted the piwik-support branch Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants