Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for the related_posts plugin. #27

Conversation

@elementalvoid
Copy link
Contributor

elementalvoid commented Feb 13, 2016

@alexandrevicenzi
If you want it, I added basic support for the related_posts plugin. It will automatically disable itself if the plugin is not enabled.

However, I don't think you'll like the DOM container that I put it in. : ) Please suggest something better than 'footer' and I'll update it. I say this because it isn't actually in the footer but I got a nice horizontal separator for free by putting it in a footer element.

@alexandrevicenzi

This comment has been minimized.

Copy link
Owner

alexandrevicenzi commented Feb 15, 2016

@elementalvoid, yeah, I dislike the footer element. It doesn't looks semantic inside an article element.

Maybe the horizontal separator could be done with an hr element, or just some CSS stuff. You could give a try, or if not, I could take a look too.

By the way, I liked this idea 😄

@elementalvoid

This comment has been minimized.

Copy link
Contributor Author

elementalvoid commented Feb 16, 2016

Okay, I'll rework without the footer.

@elementalvoid

This comment has been minimized.

Copy link
Contributor Author

elementalvoid commented Mar 2, 2016

Bump.. What do you think @alexandrevicenzi?

@alexandrevicenzi

This comment has been minimized.

Copy link
Owner

alexandrevicenzi commented Mar 2, 2016

@elementalvoid The code looks good, but how it's looks like (screenshot) and how do I setup this?

@elementalvoid

This comment has been minimized.

Copy link
Contributor Author

elementalvoid commented Mar 3, 2016

screen shot

To enable it you need to install the related_posts plugin and then add PLUGINS = ['related_posts'] to pelicanconf.py.

@alexandrevicenzi

This comment has been minimized.

Copy link
Owner

alexandrevicenzi commented Mar 3, 2016

Good job @elementalvoid

@alexandrevicenzi

This comment has been minimized.

Copy link
Owner

alexandrevicenzi commented Mar 5, 2016

@elementalvoid is it ok to merge?

I think this could be a little bit more beauty, like this example.

Do you think is it common to have covers on posts? I don't think so. Maybe we could use post title and some summary. Or just keep this way. Not sure whats the best option here.

@elementalvoid

This comment has been minimized.

Copy link
Contributor Author

elementalvoid commented Mar 9, 2016

My personal preference would be to leave it as is. I don't use cover images nor do I think that it's common to use post cover images. At least not on blogs that are using Pelican.

I could see supporting summaries as an optional thing. I'm happy with just the title though.

alexandrevicenzi added a commit that referenced this pull request Mar 9, 2016
Initial support for the related_posts plugin.
@alexandrevicenzi alexandrevicenzi merged commit ab0f263 into alexandrevicenzi:master Mar 9, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexandrevicenzi

This comment has been minimized.

Copy link
Owner

alexandrevicenzi commented Mar 9, 2016

Thanks @elementalvoid.

alexandrevicenzi added a commit to alexandrevicenzi/pelican-themes that referenced this pull request Jun 3, 2016
Changes

- [Update font-awesome](alexandrevicenzi/Flex#31)
- [Added browser color configuration](alexandrevicenzi/Flex#34)
- [Related posts](alexandrevicenzi/Flex#27)
- [More Pygments Styles](alexandrevicenzi/Flex#38)
eddiejessup added a commit to eddiejessup/pelican-themes that referenced this pull request Nov 27, 2016
Changes

- [Update font-awesome](alexandrevicenzi/Flex#31)
- [Added browser color configuration](alexandrevicenzi/Flex#34)
- [Related posts](alexandrevicenzi/Flex#27)
- [More Pygments Styles](alexandrevicenzi/Flex#38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.