New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the neighbors plugin #98

Merged
merged 5 commits into from Apr 22, 2017

Conversation

Projects
None yet
2 participants
@olipratt
Contributor

olipratt commented Mar 4, 2017

Hi,

This add support for the neighbors plugin as per #97.

This:

  • Only changes anything if you enable the 'neighbors' plugin.
  • Uses the same code/style as the pagination buttons
  • Minor fix of an overly long line and remove a duplicate DEFAULT_PAGINATION setting in tests/pelicanconf.py

Note - this adds new Previous Post and Next Post text, so don't know if this causes translation problems.

Tested on Windows 10 and Android 6, both using Chrome 56.0.2924.87 on articles with both buttons and first/last articles with only one button - all works as expected.

Here's a screenshot of the added buttons from the tests:
prevnextpostbuttons

@alexandrevicenzi

This comment has been minimized.

Show comment
Hide comment
@alexandrevicenzi

alexandrevicenzi Mar 10, 2017

Owner

@olipratt yes, it will need to be translated to all languages.

These buttons aren't placed well, they're so close. I think the should be placed at the corner of the page.

Owner

alexandrevicenzi commented Mar 10, 2017

@olipratt yes, it will need to be translated to all languages.

These buttons aren't placed well, they're so close. I think the should be placed at the corner of the page.

@alexandrevicenzi alexandrevicenzi added this to the 2.1.1 milestone Mar 14, 2017

@olipratt

This comment has been minimized.

Show comment
Hide comment
@olipratt

olipratt Mar 18, 2017

Contributor

Hi @alexandrevicenzi

Sorry for the delay I had a busy week.
I updated the CSS to remove the padding around the sides of the button container, and think it looks a lot better - hope that's what you meant. Checked it looks correct on PC and mobile.
I also updated the readme to note that the plugin is supported.

If you agree to take this change then I still need to regenerate the CSS file, but let me know what you think.

Thanks.

buttonsatedge

Contributor

olipratt commented Mar 18, 2017

Hi @alexandrevicenzi

Sorry for the delay I had a busy week.
I updated the CSS to remove the padding around the sides of the button container, and think it looks a lot better - hope that's what you meant. Checked it looks correct on PC and mobile.
I also updated the readme to note that the plugin is supported.

If you agree to take this change then I still need to regenerate the CSS file, but let me know what you think.

Thanks.

buttonsatedge

@alexandrevicenzi alexandrevicenzi merged commit a6f12ec into alexandrevicenzi:master Apr 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment