Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross build with Scala 2.13 #121

Merged
merged 1 commit into from Sep 27, 2019

Conversation

@tmccarthy
Copy link
Contributor

commented Sep 27, 2019

This PR adds support for Scala 2.13 and fixes #120.

The only tricky issue I found was with extending NativeArray in order to override getDefaultValue. I believe that the issue described in scala/bug#11575 is making it impossible to override NativeArray anonymously in Scala code. My solution was to create a new implementation in NativeArrayWithDefault.java. This feels excessive but was the best I could do. I'm open to feedback if there's a cleaner solution to the problem.

Hopefully this PR is useful. Let me know if there's any other changes required!

@alexarchambault

This comment has been minimized.

Copy link
Owner

commented Sep 27, 2019

Thanks @tmccarthy!

@alexarchambault alexarchambault merged commit 6fefac1 into alexarchambault:master Sep 27, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexarchambault

This comment has been minimized.

Copy link
Owner

commented Sep 27, 2019

Just tagged 0.7.1, that includes these changes. It'll be available once the CI built and released it, and the artifacts are sync-ed to Maven Central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.